feat(insights): conformance reports #2993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cprussin
approved these changes
Aug 28, 2025
apps/insights/src/components/ConformanceReport/conformance-report.module.scss
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/conformance-report.tsx
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/conformance-report.tsx
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/conformance-report.tsx
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/use-download-report-for-publisher.tsx
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/use-download-report-for-publisher.tsx
Outdated
Show resolved
Hide resolved
apps/insights/src/components/ConformanceReport/use-download-report-for-publisher.tsx
Show resolved
Hide resolved
| @@ -0,0 +1,37 @@ | |||
| import { z } from "zod"; | |||
Collaborator
There was a problem hiding this comment.
Personally I'm not a big fan of organizing files by the type of file, I prefer functional domain based organization; in particular I'd prefer (and expect) to find this scheme with the code that fetches the data that the schema validates.
Contributor
Author
There was a problem hiding this comment.
Changed to a separate price-feeds-schema.ts file.
what if the schema is used in different places/files?
For example, we use the schema in api routes, pyth functions (eg. getFeeds()), http request functions, etc.
Contributor
Author
|
@cprussin addressed the comments, I'll merge this but happy to go be to this again in case you have more feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Conformance reports for publishers and feeds.
Rationale
Adding missing conformance reports form the old legacy website.
How has this been tested?